Re: Add minimal C example and SQL registration example for custom table access methods.
| От | Fabrízio de Royes Mello |
|---|---|
| Тема | Re: Add minimal C example and SQL registration example for custom table access methods. |
| Дата | |
| Msg-id | CAFcNs+oZYizW7-X_MmSjFeaxtHamb6Z38zBUKDUtfuKJ8yjipA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Add minimal C example and SQL registration example for custom table access methods. (Roberto Mello <roberto.mello@gmail.com>) |
| Ответы |
Re: Add minimal C example and SQL registration example for custom table access methods.
|
| Список | pgsql-hackers |
On Wed, Nov 15, 2023 at 8:29 PM Roberto Mello <roberto.mello@gmail.com> wrote:
>
> Suggestion:
>
> In the C example you added you mention in the comment:
>
> + /* Methods from TableAmRoutine omitted from example, but all
> + non-optional ones must be provided here. */
>
> Perhaps you could provide a "see <xyz>" to point the reader finding your example where he could find these non-optional methods he must provide?
>
> Nitpicking a little: your patch appears to change more lines than it does, because it added line breaks earlier in the lines. I would generally avoid that unless there's good reason to do so.
Hey folks,
There is a previous patch [1] around the same topic. What about joining efforts on pointing these documentation changes to the proposed test module?
Fabrízio de Royes Mello
В списке pgsql-hackers по дате отправления: