Обсуждение: Re: pgsql: Doc: Update the interaction of tablesync with wal_retrieve_retry

On 1/22/25 06:34, Amit Kapila wrote:
> Doc: Update the interaction of tablesync with wal_retrieve_retry_interval.
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/4a0e7314f11ee03adfe9df945598c068b4179314

Hi,

In this sentence :

"The initial data in existing subscribed tables are snapshotted and
copied in a parallel instances of a special kind of apply process."

"copied in a parallel instances" seems wrong. It should be either
(1) singular "in a parallel instance" or
(2) plural "in parallel instances"

I'm not sure which is meant.  I also wonder if 'instance' is actually 
the correct word here at all; see the Glossary definition of 'instance':

"A group of backend and auxiliary processes that communicate
using a common shared memory area. One postmaster process
manages the instance; one instance manages exactly one database
cluster with all its databases. Many instances can run on the same
server as long as their TCP ports do not conflict."

Thanks,

Erik






> Modified Files
> --------------
> doc/src/sgml/config.sgml              |  3 ++-
> doc/src/sgml/logical-replication.sgml | 35 +++++++++++++++++++++++------------
> 2 files changed, 25 insertions(+), 13 deletions(-)
> 

On Thu, Jan 23, 2025 at 4:56 PM Erik Rijkers <er@xs4all.nl> wrote:
>
> On 1/22/25 06:34, Amit Kapila wrote:
> > Doc: Update the interaction of tablesync with wal_retrieve_retry_interval.
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> > https://git.postgresql.org/pg/commitdiff/4a0e7314f11ee03adfe9df945598c068b4179314
>
> Hi,
>
> In this sentence :
>
> "The initial data in existing subscribed tables are snapshotted and
> copied in a parallel instances of a special kind of apply process."
>
> "copied in a parallel instances" seems wrong. It should be either
> (1) singular "in a parallel instance" or
> (2) plural "in parallel instances"
>
> I'm not sure which is meant.
>

I meant the latter. It is a typo. I will fix it.

>  I also wonder if 'instance' is actually
> the correct word here at all; see the Glossary definition of 'instance':
>

It is not introduced by this patch but sounds correct to me because
the apply worker launches multiple table sync workers and they do
communicate via different states to finish the initial
synchronization.

--
With Regards,
Amit Kapila.