Обсуждение: [pgadmin4][patch] Use ESLinter options instead of using Javascript
Hi Hackers,
Attached you can find a patch that changes the way we are running ESLint on the Javascript files. Instead of using Javascript we can use ESLint parameters to archive the same goal.
In the future this will also allow us to use the rest of the cli parameters like (--fix and others...)
Thanks
Anthony && Joao
Вложения
Apologies, here's a redo that should apply cleanly on top of master
Anthony && Joao
On Mon, May 14, 2018 at 3:25 PM Anthony Emengo <aemengo@pivotal.io> wrote:
Hi Hackers,Attached you can find a patch that changes the way we are running ESLint on the Javascript files. Instead of using Javascript we can use ESLint parameters to archive the same goal.In the future this will also allow us to use the rest of the cli parameters like (--fix and others...)ThanksAnthony && Joao
Вложения
Hey all, we'd definitely like some feedback on this patch. Does does it not apply cleanly? Do we need to resend it?
Thanks
Anthony
On Mon, May 14, 2018 at 3:47 PM Anthony Emengo <aemengo@pivotal.io> wrote:
Apologies, here's a redo that should apply cleanly on top of masterAnthony && JoaoOn Mon, May 14, 2018 at 3:25 PM Anthony Emengo <aemengo@pivotal.io> wrote:Hi Hackers,Attached you can find a patch that changes the way we are running ESLint on the Javascript files. Instead of using Javascript we can use ESLint parameters to archive the same goal.In the future this will also allow us to use the rest of the cli parameters like (--fix and others...)ThanksAnthony && Joao
Hi Anthony,
The code looks good to me and working fine.
Thanks,
Khushboo
On Wed, May 16, 2018 at 9:23 PM, Anthony Emengo <aemengo@pivotal.io> wrote:
Hey all, we'd definitely like some feedback on this patch. Does does it not apply cleanly? Do we need to resend it?ThanksAnthonyOn Mon, May 14, 2018 at 3:47 PM Anthony Emengo <aemengo@pivotal.io> wrote:Apologies, here's a redo that should apply cleanly on top of masterAnthony && JoaoOn Mon, May 14, 2018 at 3:25 PM Anthony Emengo <aemengo@pivotal.io> wrote:Hi Hackers,Attached you can find a patch that changes the way we are running ESLint on the Javascript files. Instead of using Javascript we can use ESLint parameters to archive the same goal.In the future this will also allow us to use the rest of the cli parameters like (--fix and others...)ThanksAnthony && Joao
On Thu, May 17, 2018 at 11:05 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.
Hi Anthony,The code looks good to me and working fine.Thanks,KhushbooOn Wed, May 16, 2018 at 9:23 PM, Anthony Emengo <aemengo@pivotal.io> wrote:Hey all, we'd definitely like some feedback on this patch. Does does it not apply cleanly? Do we need to resend it?ThanksAnthonyOn Mon, May 14, 2018 at 3:47 PM Anthony Emengo <aemengo@pivotal.io> wrote:Apologies, here's a redo that should apply cleanly on top of masterAnthony && JoaoOn Mon, May 14, 2018 at 3:25 PM Anthony Emengo <aemengo@pivotal.io> wrote:Hi Hackers,Attached you can find a patch that changes the way we are running ESLint on the Javascript files. Instead of using Javascript we can use ESLint parameters to archive the same goal.
Thanks - committed!
In the future this will also allow us to use the rest of the cli parameters like (--fix and others...)
We can still use other command line options like this:
$ yarn run linter --fix webpack.config.js
yarn run v1.6.0
$ yarn eslint --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx . --fix webpack.config.js
$ /XXX/pgAdmin4/web/node_--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
ThanksAnthony && Joao