Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript
| От | Khushboo Vashi |
|---|---|
| Тема | Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript |
| Дата | |
| Msg-id | CAFOhELfbA-7+kYATQMm4jLgb77B_yxBVH1u5VJ8ij9-Ms8fNjg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript (Anthony Emengo <aemengo@pivotal.io>) |
| Ответы |
Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript
|
| Список | pgadmin-hackers |
Hi Anthony,
The code looks good to me and working fine.
Thanks,
Khushboo
On Wed, May 16, 2018 at 9:23 PM, Anthony Emengo <aemengo@pivotal.io> wrote:
Hey all, we'd definitely like some feedback on this patch. Does does it not apply cleanly? Do we need to resend it?ThanksAnthonyOn Mon, May 14, 2018 at 3:47 PM Anthony Emengo <aemengo@pivotal.io> wrote:Apologies, here's a redo that should apply cleanly on top of masterAnthony && JoaoOn Mon, May 14, 2018 at 3:25 PM Anthony Emengo <aemengo@pivotal.io> wrote:Hi Hackers,Attached you can find a patch that changes the way we are running ESLint on the Javascript files. Instead of using Javascript we can use ESLint parameters to archive the same goal.In the future this will also allow us to use the rest of the cli parameters like (--fix and others...)ThanksAnthony && Joao
В списке pgadmin-hackers по дате отправления: