Обсуждение: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window.

Поиск
Список
Период
Сортировка

[pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window.

От
Khushboo Vashi
Дата:
Hi,

Please find the attached patch for RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

Shortcuts provided in this patch:

Alt+Shift+Q Open the query tool
Alt+Shift+V View data
Alt+Shift+C Open the context menu
Alt+Shift+N Create an object
Alt+Shift+E Edit the object properties
Alt+Shift+D Delete the object
Alt+Shift+G Direct debugging


Thanks,
Khushboo
Вложения

Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window.

От
Joao De Almeida Pereira
Дата:
Hello Khushboo,
We were looking into the your patch and have some questions.

  - What is the reason being the front end shortcuts being registered in the python code? There is already some precedent in the code, but this looks like a concern of the front end.
  - Didn't saw any tests around this, did you create them?
  
While testing it out, in the Mac, when I press Option + Shift + E while selecting 'Tables' node, no information is given to the user that the object as no properties, like Option + Shift + V does, is this intentional?(Same with Option + Shift + D)

In which situation can Direct debugging be used?
Should the documentation specify the Shortcuts for Mac as well?


Thanks
Joao

On Thu, Feb 8, 2018 at 2:08 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

Shortcuts provided in this patch:

Alt+Shift+Q Open the query tool
Alt+Shift+V View data
Alt+Shift+C Open the context menu
Alt+Shift+N Create an object
Alt+Shift+E Edit the object properties
Alt+Shift+D Delete the object
Alt+Shift+G Direct debugging


Thanks,
Khushboo

Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window.

От
Khushboo Vashi
Дата:
Hi Joao,

On Thu, Feb 8, 2018 at 7:57 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Khushboo,
We were looking into the your patch and have some questions.

  - What is the reason being the front end shortcuts being registered in the python code? There is already some precedent in the code, but this looks like a concern of the front end.
 
We have given customisable keyboard shortcuts through preferences dialogue and to do so we need to register them first.
  - Didn't saw any tests around this, did you create them?
 
Added feature test for the keyboard shortcuts in my previous patch which was committed.
  
While testing it out, in the Mac, when I press Option + Shift + E while selecting 'Tables' node, no information is given to the user that the object as no properties, like Option + Shift + V does, is this intentional?(Same with Option + Shift + D)

 
They are collection nodes and it is quite obvious that they can not be edited, so as per me, no need for extra information.
In which situation can Direct debugging be used?
 
Just provided the shortcut for it, the detailed information can be found @https://www.pgadmin.org/docs/pgadmin4/2.x/debugger.html
Should the documentation specify the Shortcuts for Mac as well?


Shortcuts are not specific to the platform, they are common for all the platforms and the document also specify the same.

Thanks
Joao

Thanks,
Khushboo 
On Thu, Feb 8, 2018 at 2:08 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

Shortcuts provided in this patch:

Alt+Shift+Q Open the query tool
Alt+Shift+V View data
Alt+Shift+C Open the context menu
Alt+Shift+N Create an object
Alt+Shift+E Edit the object properties
Alt+Shift+D Delete the object
Alt+Shift+G Direct debugging


Thanks,
Khushboo

Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window.

От
Dave Page
Дата:
Thanks, applied!

A couple of things that need some more investigation/thought though:

- Pressing Escape in the Query Tool and then using Alt+Shift+[ (or ] ) seems to behave oddly:

  - Sometimes it will work once, but then won't navigate to additional tabs.
  - It often seems to fill the Codemirror on the query tool with garbage.

I suspect what is happening is that although it's hidden, the Codemirror instance is grabbing the second and subsequent key presses and trying to display them.

- Should we put the shortcuts on the main menus? We have them on tooltips and button menus elsewhere, so it seems like we should.

On Thu, Feb 8, 2018 at 7:08 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

Shortcuts provided in this patch:

Alt+Shift+Q Open the query tool
Alt+Shift+V View data
Alt+Shift+C Open the context menu
Alt+Shift+N Create an object
Alt+Shift+E Edit the object properties
Alt+Shift+D Delete the object
Alt+Shift+G Direct debugging


Thanks,
Khushboo



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company