Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window.
| От | Khushboo Vashi |
|---|---|
| Тема | Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window. |
| Дата | |
| Msg-id | CAFOhELd45uF+_p3tzWLk7aWTqK-uCarf6rUaKXfsExWoBsx0jg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window. (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>) |
| Список | pgadmin-hackers |
Hi Joao,
On Thu, Feb 8, 2018 at 7:57 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Khushboo,We were looking into the your patch and have some questions.- What is the reason being the front end shortcuts being registered in the python code? There is already some precedent in the code, but this looks like a concern of the front end.
We have given customisable keyboard shortcuts through preferences dialogue and to do so we need to register them first.
- Didn't saw any tests around this, did you create them?
Added feature test for the keyboard shortcuts in my previous patch which was committed.
While testing it out, in the Mac, when I press Option + Shift + E while selecting 'Tables' node, no information is given to the user that the object as no properties, like Option + Shift + V does, is this intentional?(Same with Option + Shift + D)
They are collection nodes and it is quite obvious that they can not be edited, so as per me, no need for extra information.
In which situation can Direct debugging be used?
Just provided the shortcut for it, the detailed information can be found @https://www.pgadmin.org/docs/pgadmin4/2.x/debugger.html
Should the documentation specify the Shortcuts for Mac as well?
Shortcuts are not specific to the platform, they are common for all the platforms and the document also specify the same.
ThanksJoao
Thanks,
Khushboo
On Thu, Feb 8, 2018 at 2:08 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch for RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.Shortcuts provided in this patch:Alt+Shift+Q Open the query toolAlt+Shift+V View dataAlt+Shift+C Open the context menuAlt+Shift+N Create an objectAlt+Shift+E Edit the object propertiesAlt+Shift+D Delete the objectAlt+Shift+G Direct debuggingThanks,Khushboo
В списке pgadmin-hackers по дате отправления: