Обсуждение: [pgadmin-hackers] [patch] update table name in confirmation dialogfor 'Reset Statistics' and 'Truncate Table'

Hi

Please see the discussion here: https://redmine.postgresql.org/issues/2308

Would moving to the client-side translation mechanism help here? We need to do that anyway - and it's been added since the previous discussion.

On Thu, May 18, 2017 at 10:17 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi All 

I have found one issue where table name is not displaying in the confirmation dialog when user click on "Reset Statistics" and "Truncate/Truncate cascade". Confirmation dialog shows below message:

• Are you sure you want to truncate table {}?
• Are you sure you want to reset the statistics for table {}?
  

Also header is missing for "Truncate/Truncate cascade" confirmation dialog. Attached is the patch file to fix that above. Please review it.

--

Akshay Joshi

Principal Software Engineer 

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, May 18, 2017 at 3:00 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

Please see the discussion here: https://redmine.postgresql.org/issues/2308

Would moving to the client-side translation mechanism help here? We need to do that anyway - and it's been added since the previous discussion.

   OK, at least we should checked-in code for showing title of the confirmation dialog for "Truncate". 

On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Thu, May 18, 2017 at 3:00 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

Please see the discussion here: https://redmine.postgresql.org/issues/2308

Would moving to the client-side translation mechanism help here? We need to do that anyway - and it's been added since the previous discussion.

   OK, at least we should checked-in code for showing title of the confirmation dialog for "Truncate". 

Right, but it doesn't work. See the first comment in the bug.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, May 18, 2017 at 3:23 PM, Dave Page <dpage@pgadmin.org> wrote:

On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Thu, May 18, 2017 at 3:00 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

Please see the discussion here: https://redmine.postgresql.org/issues/2308

Would moving to the client-side translation mechanism help here? We need to do that anyway - and it's been added since the previous discussion.

   OK, at least we should checked-in code for showing title of the confirmation dialog for "Truncate". 

Right, but it doesn't work. See the first comment in the bug.

    I am talking about the header title of the confirmation dialog. If we click on Truncate table without opening any alertify dialog header shows "AlertifyJS" and if any other alertify dialog opens before then it shows the header title of that dialog even if user clicks on Truncate. Please refer attached screenshot.