Обсуждение: Re: [PATCHES] Should libedit be preferred to

Поиск
Список
Период
Сортировка

Re: [PATCHES] Should libedit be preferred to

От
"Chuck McDevitt"
Дата:
Another vote for libedit support... We at Greenplum definitely want to
use it.




Re: [PATCHES] Should libedit be preferred to

От
"Joshua D. Drake"
Дата:
Chuck McDevitt wrote:

>Another vote for libedit support... We at Greenplum definitely want to
>use it.
>  
>
If we are going to move toward libedit then libedit should be included 
in core. Otherwise
you are creating a dependency on the largest postgresql used OS (linux). 
The advantage
here of course is that we would be able to eliminate readline support 
and focus only on
libedit.

The downside is yet another software in core.

Sincerely,

Joshua D. Drake



>
>
>---------------------------(end of broadcast)---------------------------
>TIP 2: Don't 'kill -9' the postmaster
>  
>


-- 
The PostgreSQL Company - Command Prompt, Inc. 1.503.667.4564
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Managed Services, Shared and Dedicated Hosting
Co-Authors: PLphp, PLperl - http://www.commandprompt.com/



Re: [PATCHES] Should libedit be preferred to

От
Tom Lane
Дата:
"Joshua D. Drake" <jd@commandprompt.com> writes:
> If we are going to move toward libedit then libedit should be included 
> in core.

We already do support libedit; support does not mean "include", for
either readline or libedit.

I think it'd be reasonable to provide a configure option to control
selection of libedit or readline on platforms where both are (or
appear to be) available.  I'm not excited about changing the default
behavior, though, especially not on the grounds that "IBM just broke
readline on AIX and therefore we should deprecate readline everywhere",
which appears to be the reasoning offered so far.
        regards, tom lane