Обсуждение: Fix for issue RM1336 [pgadmin4]

Hi,

Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is
significantly less convenient than F5.

On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PAF patch for issue RM1336
>
> Changes: Added keyboard shortcuts (static/non configurable) to some query
> tool operations.
>
> Execute  -->   Ctrl + Shift + E
> Explain  -->    Ctrl + Shift + X
> Explain analyze  -->   Ctrl + Shift + A
>
> Note: Keyboard shortcuts do not work if focus is set on any disabled button
> inside query tool or out side the query tool.
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks!

On Thu, Jun 16, 2016 at 11:40 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> Ok, I'll change shortcut keys
>
> New shortcuts would be:
>
> Execute  -->   F5
> Explain  -->    F7
> Explain analyze  --> Shift+F7
>
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 16, 2016 at 4:03 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi,
>>
>> Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is
>> significantly less convenient than F5.
>>
>> On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal
>> <harshal.dhumal@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > PAF patch for issue RM1336
>> >
>> > Changes: Added keyboard shortcuts (static/non configurable) to some
>> > query
>> > tool operations.
>> >
>> > Execute  -->   Ctrl + Shift + E
>> > Explain  -->    Ctrl + Shift + X
>> > Explain analyze  -->   Ctrl + Shift + A
>> >
>> > Note: Keyboard shortcuts do not work if focus is set on any disabled
>> > button
>> > inside query tool or out side the query tool.
>> >
>> >
>> > --
>> > Harshal Dhumal
>> > Software Engineer
>> >
>> > EnterpriseDB India: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi

Hmm, I guess that's system dependent. What about Ctrl+F5? Or we bite
the bullet and make it configurable.

On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> Function keys won't work properly with browser as they already have
> predefined bindings.
>
> e.g.
>
> F5 for refresh (standard)
> F7 for Caret Browsing in firefox
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 16, 2016 at 4:10 PM, Harshal Dhumal
> <harshal.dhumal@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> Ok, I'll change shortcut keys
>>
>> New shortcuts would be:
>>
>> Execute  -->   F5
>> Explain  -->    F7
>> Explain analyze  --> Shift+F7
>>
>>
>>
>> --
>> Harshal Dhumal
>> Software Engineer
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Jun 16, 2016 at 4:03 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi,
>>>
>>> Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is
>>> significantly less convenient than F5.
>>>
>>> On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal
>>> <harshal.dhumal@enterprisedb.com> wrote:
>>> > Hi,
>>> >
>>> > PAF patch for issue RM1336
>>> >
>>> > Changes: Added keyboard shortcuts (static/non configurable) to some
>>> > query
>>> > tool operations.
>>> >
>>> > Execute  -->   Ctrl + Shift + E
>>> > Explain  -->    Ctrl + Shift + X
>>> > Explain analyze  -->   Ctrl + Shift + A
>>> >
>>> > Note: Keyboard shortcuts do not work if focus is set on any disabled
>>> > button
>>> > inside query tool or out side the query tool.
>>> >
>>> >
>>> > --
>>> > Harshal Dhumal
>>> > Software Engineer
>>> >
>>> > EnterpriseDB India: http://www.enterprisedb.com
>>> > The Enterprise PostgreSQL Company
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> As per my offline discussion with Ashesh; He is suggesting not to use
> Function keys as shortcuts.

Why? That is primarily what they are on the keyboard for.

> And regarding configurable key options, I suspect It is going to be time
> consuming task, please let me know if you want me to start working it. Or
> can we keep current shortcuts from my last patch?

Surely we can come up with some simple ones that will be intuitive and work?

>
> On Thu, Jun 16, 2016 at 4:19 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> Hmm, I guess that's system dependent. What about Ctrl+F5? Or we bite
>> the bullet and make it configurable.
>>
>> On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal
>> <harshal.dhumal@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > Function keys won't work properly with browser as they already have
>> > predefined bindings.
>> >
>> > e.g.
>> >
>> > F5 for refresh (standard)
>> > F7 for Caret Browsing in firefox
>> >
>> >
>> > --
>> > Harshal Dhumal
>> > Software Engineer
>> >
>> > EnterpriseDB India: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Thu, Jun 16, 2016 at 4:10 PM, Harshal Dhumal
>> > <harshal.dhumal@enterprisedb.com> wrote:
>> >>
>> >> Hi Dave,
>> >>
>> >> Ok, I'll change shortcut keys
>> >>
>> >> New shortcuts would be:
>> >>
>> >> Execute  -->   F5
>> >> Explain  -->    F7
>> >> Explain analyze  --> Shift+F7
>> >>
>> >>
>> >>
>> >> --
>> >> Harshal Dhumal
>> >> Software Engineer
>> >>
>> >> EnterpriseDB India: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >> On Thu, Jun 16, 2016 at 4:03 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>>
>> >>> Hi,
>> >>>
>> >>> Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is
>> >>> significantly less convenient than F5.
>> >>>
>> >>> On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal
>> >>> <harshal.dhumal@enterprisedb.com> wrote:
>> >>> > Hi,
>> >>> >
>> >>> > PAF patch for issue RM1336
>> >>> >
>> >>> > Changes: Added keyboard shortcuts (static/non configurable) to some
>> >>> > query
>> >>> > tool operations.
>> >>> >
>> >>> > Execute  -->   Ctrl + Shift + E
>> >>> > Explain  -->    Ctrl + Shift + X
>> >>> > Explain analyze  -->   Ctrl + Shift + A
>> >>> >
>> >>> > Note: Keyboard shortcuts do not work if focus is set on any disabled
>> >>> > button
>> >>> > inside query tool or out side the query tool.
>> >>> >
>> >>> >
>> >>> > --
>> >>> > Harshal Dhumal
>> >>> > Software Engineer
>> >>> >
>> >>> > EnterpriseDB India: http://www.enterprisedb.com
>> >>> > The Enterprise PostgreSQL Company
>> >>> >
>> >>> >
>> >>> > --
>> >>> > Sent via pgadmin-hackers mailing list
>> >>> > (pgadmin-hackers@postgresql.org)
>> >>> > To make changes to your subscription:
>> >>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Dave Page
>> >>> Blog: http://pgsnake.blogspot.com
>> >>> Twitter: @pgsnake
>> >>>
>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jun 16, 2016 at 3:28 PM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> On Thu, Jun 16, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal
>> <harshal.dhumal@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > As per my offline discussion with Ashesh; He is suggesting not to use
>> > Function keys as shortcuts.
>>
>> Why? That is primarily what they are on the keyboard for.
>
> F5 is always bind to refresh function of the browser on linux & windows.
> Similarly - many shortcuts of browser are bound to the function keys.
>
> Hence - I asked not to use F5.

I suggested Ctrl+F5.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

OK, applied as-is for now. I guess all our shortcuts will probably end
up being Ctrl+Shift+Something :-(

On Mon, Jun 20, 2016 at 10:45 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> I tried to find unique shortcuts keys combination using function keys on
> different platforms (windows, mac, linux ) but no success. Any combination
> of function keys with either of (or some of them together) Alt, Ctrl, Shift
> conflict with either browser functionality or with window functionality
> (like resize, move, minimize, maximize etc).
>
> And regarding Ctrl+F5, it is for hard refresh on some browsers.
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 16, 2016 at 8:03 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Thu, Jun 16, 2016 at 3:28 PM, Ashesh Vashi
>> <ashesh.vashi@enterprisedb.com> wrote:
>> > On Thu, Jun 16, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal
>> >> <harshal.dhumal@enterprisedb.com> wrote:
>> >> > Hi,
>> >> >
>> >> > As per my offline discussion with Ashesh; He is suggesting not to use
>> >> > Function keys as shortcuts.
>> >>
>> >> Why? That is primarily what they are on the keyboard for.
>> >
>> > F5 is always bind to refresh function of the browser on linux & windows.
>> > Similarly - many shortcuts of browser are bound to the function keys.
>> >
>> > Hence - I asked not to use F5.
>>
>> I suggested Ctrl+F5.
>
>
>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

I'm just wondering what the thought process is for making the shortcuts configurable, or why that's going to be significantly hard? I find that to be highly desirable feature, one of the reasons being avoiding something like this from happening (with browser bindings). Some of us have other tools which are also unconfigurable and bind to the same keys, and now you have conflicts between them.

However, what I think doesn't matter at all in the scheme of things, I'm just throwing in my $0.02.

Thanks,
-Adam

On Mon, Jun 20, 2016 at 2:29 PM, Adam Brusselback
<adambrusselback@gmail.com> wrote:
> I'm just wondering what the thought process is for making the shortcuts
> configurable, or why that's going to be significantly hard? I find that to
> be highly desirable feature, one of the reasons being avoiding something
> like this from happening (with browser bindings). Some of us have other
> tools which are also unconfigurable and bind to the same keys, and now you
> have conflicts between them.
>
> However, what I think doesn't matter at all in the scheme of things, I'm
> just throwing in my $0.02.

It's not that it's necessarily hard, it's that there are only 24 hours
in the day to get things done. We've got a long list of improvements
to make - some immediate (i.e. in time for betaX - 2 being today in
fact), others for GA and others for future releases. Meanwhile, much
as I'd like to, I cannot keep 10 people assigned to pgAdmin
indefinitely. I do need to get them working on other projects, for
which there are also deadlines.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 20/06/16 09:33, Dave Page wrote:
> It's not that it's necessarily hard, it's that there are only 24 hours
> in the day to get things done. We've got a long list of improvements
> to make - some immediate (i.e. in time for betaX - 2 being today in
> fact), others for GA and others for future releases. Meanwhile, much
> as I'd like to, I cannot keep 10 people assigned to pgAdmin
> indefinitely. I do need to get them working on other projects, for
> which there are also deadlines.
Since pgadmin4 is at the top of the stack browser - window environment -
OS - kernel, all of which have their call on some specific set of
shortcuts, a couple of thoughts:
1. are there other applications similar to pgadmin which are in the same
position where they too are looking for shortcuts? In which case is
there a possibility of cross-fertilization of ideas?
2. in the world of software shortcuts, the needs of dependent
applications such as pgadmin might not have been foreseen, but is there
in the hierarchy a moral obligation to keep a certain subset of
combinations free? At the moment it seems like a free for all...

On Mon, Jun 20, 2016 at 2:51 PM, Colin Beckingham <colbec@kingston.net> wrote:
>
> On 20/06/16 09:33, Dave Page wrote:
>>
>> It's not that it's necessarily hard, it's that there are only 24 hours in
>> the day to get things done. We've got a long list of improvements to make -
>> some immediate (i.e. in time for betaX - 2 being today in fact), others for
>> GA and others for future releases. Meanwhile, much as I'd like to, I cannot
>> keep 10 people assigned to pgAdmin indefinitely. I do need to get them
>> working on other projects, for which there are also deadlines.
>
> Since pgadmin4 is at the top of the stack browser - window environment - OS
> - kernel, all of which have their call on some specific set of shortcuts, a
> couple of thoughts:
> 1. are there other applications similar to pgadmin which are in the same
> position where they too are looking for shortcuts? In which case is there a
> possibility of cross-fertilization of ideas?

The only app I've found so far like that is Gmail, but 95% of it's
shortcuts are single keys that only work when you're not already
focussed in an editable field. In pgAdmin, that doesn't help much in
cases like this, when you're likely editing a query.

> 2. in the world of software shortcuts, the needs of dependent applications
> such as pgadmin might not have been foreseen, but is there in the hierarchy
> a moral obligation to keep a certain subset of combinations free? At the
> moment it seems like a free for all...

Yeah, you'd think there should be some moral obligation, but you're
right - it is a free for all.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi

On Wed, Jun 29, 2016 at 7:05 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA upadated patch for RM1336
>
> Issue fixed: Query tool shortcuts weren't working on mac runtime. Also
> changed shortcut key for "Explain analyze" from Ctrl+Shift+A --->
> Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show "about"
> dialog in runtime.

Thanks - but let's change the runtime and go back to Ctrl+Shift+A in
the app. The About box in the runtime is really unimportant.



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi

On Wed, Jun 29, 2016 at 7:32 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> Here is updated patch for RM1336
>
> Fixed query tool shortcuts issue in Mac runtime and changed shortcut to show
> "About" dialog in runtime from Ctrl+Shift+A ----> Alt+Shift+A

I updated the runtime to use Alt+Shift+A, as well as changing the
other shortcuts to use Alt+Shift to avoid future collisions.

However, the shortcuts in the app still don't work in the runtime for
me, so I haven't applied the other change.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi Harshal,

On Thu, Jun 30, 2016 at 7:59 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> Somehow control key is mapped to Command key in Mac. So on Mac shortcuts are
> Shift+Command+E, Shift+Command+X, Shift+Command+A

OK, those work, but I think we need to take a step back here (partly
because Cmd+Shift+A seems to be Select All in CodeMirror on Mac). I've
committed the patch now, but changed Ctrl+Shift+A to Ctrl+Shift+N.

Can you please work on the following:

1) Create a table of shortcuts from our runtime, our web app, and
CodeMirror. This should list:

Component (e.g. runtime, CodeMirror, Query Tool)
Standard shortcut (e.g. Ctrl+Shift+A)
Mac shortcut (e.g. Cmd+Shift+A)
Function (e.g. Explain Analyze or Select All)

Let's make this as complete and accurate as possible, so it can be
included in the documentation, and used by us to select or
de-duplicate shortcuts.

2) Confirm that the shortcuts we're using in our runtime and web
application don't conflict with any in CodeMirror (or web browsers, in
the case of the web app).

3) Update the web application so the shortcuts are correctly displayed
on Mac automatically - e.g. the tooltips and menus should show
Cmd+Shift not Ctrl+Shift

4) Investigate #1360, and ensure that the CodeMirror shortcuts work
consistently between the runtime and browsers on all platforms.

5) Investigate any remaining shortcuts that don't work as expected.

Thanks, Dave.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi

On Fri, Jul 1, 2016 at 11:10 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA patch
>
> This contains:
> 1] All shortcuts' list which we are using in pgAdmin4.
> 2] Fixed shortcut display tooltips.
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 30, 2016 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi Harshal,
>>
>> On Thu, Jun 30, 2016 at 7:59 AM, Harshal Dhumal
>> <harshal.dhumal@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > Somehow control key is mapped to Command key in Mac. So on Mac shortcuts
>> > are
>> > Shift+Command+E, Shift+Command+X, Shift+Command+A
>>
>> OK, those work, but I think we need to take a step back here (partly
>> because Cmd+Shift+A seems to be Select All in CodeMirror on Mac). I've
>> committed the patch now, but changed Ctrl+Shift+A to Ctrl+Shift+N.
>>
>> Can you please work on the following:
>>
>> 1) Create a table of shortcuts from our runtime, our web app, and
>> CodeMirror. This should list:
>>
>> Component (e.g. runtime, CodeMirror, Query Tool)
>> Standard shortcut (e.g. Ctrl+Shift+A)
>> Mac shortcut (e.g. Cmd+Shift+A)
>> Function (e.g. Explain Analyze or Select All)
>>
>> Let's make this as complete and accurate as possible, so it can be
>> included in the documentation, and used by us to select or
>> de-duplicate shortcuts.
>
> Added shortcuts' list.

Let's keep it as a separate file for now, and not part of the source
tree or any patches.

I notice that it's missing much of what I wanted to collect though, e.g.

Ctrl+Space - Autocomplete(?)
Cut
Copy
Paste
Select All
...

The other CodeMirror keys can be found at
https://codemirror.net/doc/manual.html#keymaps. Please add at least
the basic editting commands.

>> 2) Confirm that the shortcuts we're using in our runtime and web
>> application don't conflict with any in CodeMirror (or web browsers, in
>> the case of the web app).
>
> Tested. No other conflicting shortcuts found.

Good.

>>
>> 3) Update the web application so the shortcuts are correctly displayed
>> on Mac automatically - e.g. the tooltips and menus should show
>> Cmd+Shift not Ctrl+Shift
>
> Fixed
>
>>
>>
>> 4) Investigate #1360, and ensure that the CodeMirror shortcuts work
>> consistently between the runtime and browsers on all platforms.
>
> Investigating now.

You've already found one inconsistency - Cmd vs. Ctrl on Mac browsers
vs. the runtime. It should be Cmd in either UI, to avoid user
confusion.

>>
>> 5) Investigate any remaining shortcuts that don't work as expected.
>
>
> Investigating now.: Codemirror shortcut (Cmd/Ctrl+Shift+A)  "Select all"
> only works on Mac (web/runtime) not on linux platform (haven't tested on
> windows)

Yeah - see also some of the comments I made on
https://redmine.postgresql.org/issues/1360

Let's figure out what's wrong first, then come up with a set of
fixes/changes that will get us to a consistent set of keys that work
as per the list you're preparing.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi

On Mon, Jul 4, 2016 at 3:00 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA updated patch for RM1336 and keyboard shortcuts file separately.
>
> This patch is same as last patch except I have removed keyboard shortcut
> list from this patch.
>
> Also please see my inline response below.
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Jul 1, 2016 at 5:46 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Fri, Jul 1, 2016 at 11:10 AM, Harshal Dhumal
>> <harshal.dhumal@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > PFA patch
>> >
>> > This contains:
>> > 1] All shortcuts' list which we are using in pgAdmin4.
>> > 2] Fixed shortcut display tooltips.
>> >
>> >
>> > --
>> > Harshal Dhumal
>> > Software Engineer
>> >
>> > EnterpriseDB India: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Thu, Jun 30, 2016 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi Harshal,
>> >>
>> >> On Thu, Jun 30, 2016 at 7:59 AM, Harshal Dhumal
>> >> <harshal.dhumal@enterprisedb.com> wrote:
>> >> > Hi Dave,
>> >> >
>> >> > Somehow control key is mapped to Command key in Mac. So on Mac
>> >> > shortcuts
>> >> > are
>> >> > Shift+Command+E, Shift+Command+X, Shift+Command+A
>> >>
>> >> OK, those work, but I think we need to take a step back here (partly
>> >> because Cmd+Shift+A seems to be Select All in CodeMirror on Mac). I've
>> >> committed the patch now, but changed Ctrl+Shift+A to Ctrl+Shift+N.
>> >>
>> >> Can you please work on the following:
>> >>
>> >> 1) Create a table of shortcuts from our runtime, our web app, and
>> >> CodeMirror. This should list:
>> >>
>> >> Component (e.g. runtime, CodeMirror, Query Tool)
>> >> Standard shortcut (e.g. Ctrl+Shift+A)
>> >> Mac shortcut (e.g. Cmd+Shift+A)
>> >> Function (e.g. Explain Analyze or Select All)
>> >>
>> >> Let's make this as complete and accurate as possible, so it can be
>> >> included in the documentation, and used by us to select or
>> >> de-duplicate shortcuts.
>> >
>> > Added shortcuts' list.
>>
>> Let's keep it as a separate file for now, and not part of the source
>> tree or any patches.
>>
>> I notice that it's missing much of what I wanted to collect though, e.g.
>>
>> Ctrl+Space - Autocomplete(?)
>> Cut
>> Copy
>> Paste
>> Select All
>> ...
>>
>>
>> The other CodeMirror keys can be found at
>> https://codemirror.net/doc/manual.html#keymaps. Please add at least
>> the basic editting commands.
>
> Yes I have added basic codemirror shortcuts in file.

Thanks.

>> >> 4) Investigate #1360, and ensure that the CodeMirror shortcuts work
>> >> consistently between the runtime and browsers on all platforms.
>> >
>> > Investigating now.
>>
>> You've already found one inconsistency - Cmd vs. Ctrl on Mac browsers
>> vs. the runtime. It should be Cmd in either UI, to avoid user
>> confusion.
>
> Yes, UI will now show Ctrl or Cmd depending on os platform and application
> mode (web/runtime). (This was also there in last patch)

You are missing my point I think - the shortcuts should not be
different in the runtime; if they are, they need to be fixed. If I'm
on a Mac, the shortcuts should be the same in both the browser and
runtime for example.

>> >> 5) Investigate any remaining shortcuts that don't work as expected.
>> >
>> >
>> > Investigating now.: Codemirror shortcut (Cmd/Ctrl+Shift+A)  "Select all"
>> > only works on Mac (web/runtime) not on linux platform (haven't tested on
>> > windows)
>
> "Select all" was working on linux as well. It was my mistake. I have added
> shortcut key details in keyboard shortcut file.

OK.

>> Yeah - see also some of the comments I made on
>> https://redmine.postgresql.org/issues/1360
>>
> I spend some time debugging this but didn't get what's going wrong here.

I think the point is that you need to verify that the set of shortcuts
in your text file work correct in both browsers and the runtime, on
Windows, Mac and Linux - and if not, which ones are broken, and how do
we fix them.

The ultimate aim is to ensure we have consistent, working shortcuts
(with only Ctrl vs. Cmd being a different on Macs).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company