Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs
От | Peter Eisentraut |
---|---|
Тема | Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs |
Дата | |
Msg-id | dcccf6bb-8a4e-4318-870a-e78252a5f0b2@eisentraut.org обсуждение исходный текст |
Ответ на | Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs (Nazir Bilal Yavuz <byavuz81@gmail.com>) |
Ответы |
Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs
|
Список | pgsql-hackers |
On 14.12.23 14:40, Nazir Bilal Yavuz wrote: > On Fri, 6 Oct 2023 at 17:07, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> >> As a quick cross-check, I searched our commit log to see how many >> README-only commits there were so far this year. I found 11 since >> January. (Several were triggered by the latest round of pgindent >> code and process changes, so maybe this is more than typical.) >> >> Not sure what that tells us about the value of changing the CI >> logic, but it does seem like it could be worth the one-liner >> change needed to teach buildfarm animals to ignore READMEs. > > I agree that it could be worth implementing this logic on buildfarm animals. > > In case we want to implement the same logic on the CI, I added a new > version of the patch; it skips CI completely if the changes are only > in the README files. I don't see how this could be applicable widely enough to be useful: - While there are some patches that touch on README files, very few of those end up in a commit fest. - If someone manually pushes a change to their own CI environment, I don't see why we need to second-guess that. - Buildfarm runs generally batch several commits together, so it is very unlikely that this would be hit. I think unless some concrete reason for this change can be shown, we should drop it.
В списке pgsql-hackers по дате отправления: