Re: Minimal logical decoding on standbys

Hi,

On 4/4/23 7:53 PM, Andres Freund wrote:
> Hi,
> 
> On 2023-04-04 18:54:33 +0200, Drouvot, Bertrand wrote:
>>      if (check_on_xid)
>>      {
>>          if (terminating)
>>              appendStringInfo(&err_msg, _("terminating process %d to release replication slot \"%s\" because it
conflictswith recovery"),
 
>>                               pid,
>>                               NameStr(slotname));
> 
> FWIW, I would just use exactly the same error message as today here.
> 
>                         errmsg("terminating process %d to release replication slot \"%s\"",
>                                active_pid, NameStr(slotname)),
> 
> This is accurate for both the existing and the new case. Then there's no need
> to put that string into a stringinfo either.
> 

Right, thanks! Did it that way in V60 attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com