Re: [patch] ENUM errdetail should mention bytes, not chars

On 2020-10-19 06:34, Julien Rouhaud wrote:
>>      ERROR:  invalid enum label "ああああああああああああああああああああああ"
>>      DETAIL:  Labels must be 63 characters or less.
>>
>> Attached trivial patch changes the message to:
>>
>>      DETAIL:  Labels must be 63 bytes or less.
>>
>> This matches the documentation, which states:
>>
>>      The length of an enum value's textual label is limited by the NAMEDATALEN
>>      setting compiled into PostgreSQL; in standard builds this means at most
>>      63 bytes.
>>
>>      https://www.postgresql.org/docs/current/datatype-enum.html
>>
>> I don't see any particular need to backpatch this.
> 
> Indeed the message is wrong, and patch LGTM.

Committed.  Btw., the patch didn't update the regression test output.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services