Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
Дата
Msg-id Ynm4ecSwODdS23EA@paquier.xyz
обсуждение исходный текст
Ответ на Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa  (Andrew Dunstan <andrew@dunslane.net>)
Ответы Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-committers
On Mon, May 09, 2022 at 10:10:27AM -0400, Andrew Dunstan wrote:
> The system() call should include redirection, since we only case about
> the return code.

Okay, done using File::Spec::devnull.

> I would just write this
>
> as
>
>     $ENV{$envname} = $envdefault if $rc == 0;
>
> There should be no need to set it to the empty string in case if
> failure, we already know it's undefined.

This needs to be adjusted on all the stable branches, so I'll do that
once this week's version is tagged.  Attached is an updated patch for
now.
--
Michael

Вложения

В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Stamp 10.21.
Следующее
От: Michael Paquier
Дата:
Сообщение: pgsql: Fix several issues with the TAP tests of pg_upgrade