Re: Remove a unused argument from qual_is_pushdown_safe

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Remove a unused argument from qual_is_pushdown_safe
Дата
Msg-id Y4RmBNzVXvTSDmIG@paquier.xyz
обсуждение исходный текст
Ответ на Re: Remove a unused argument from qual_is_pushdown_safe  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Remove a unused argument from qual_is_pushdown_safe  (Yugo NAGATA <nagata@sraoss.co.jp>)
Re: Remove a unused argument from qual_is_pushdown_safe  (Richard Guo <guofenglinux@gmail.com>)
Re: Remove a unused argument from qual_is_pushdown_safe  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Mon, Nov 28, 2022 at 11:54:45AM +0900, Michael Paquier wrote:
> On Fri, Nov 25, 2022 at 04:05:13PM +0800, Richard Guo wrote:
>> I wonder if we need to revise the comment atop qual_is_pushdown_safe()
>> too which says
>>
>>  * rinfo is a restriction clause applying to the given subquery (whose RTE
>>  * has index rti in the parent query).
>>
>> since there is no 'given subquery' after we remove it from the params.

I was thinking about this point, and it seems to me that we could just
do s/the given subquery/a subquery/.  But perhaps you have a different
view on the matter?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michail Nikolaev
Дата:
Сообщение: Re: Slow standby snapshot
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Fix comment in SnapBuildFindSnapshot