Re: Add support for specifying tables in pg_createsubscriber.

Поиск
Список
Период
Сортировка
От Chao Li
Тема Re: Add support for specifying tables in pg_createsubscriber.
Дата
Msg-id E6E1F4E3-DABF-4F23-A64A-B7C883F2A9E1@gmail.com
обсуждение исходный текст
Ответ на Re: Add support for specifying tables in pg_createsubscriber.  (Shubham Khanna <khannashubham1197@gmail.com>)
Ответы Re: Add support for specifying tables in pg_createsubscriber.
Список pgsql-hackers
Дерево обсуждения

On Sep 25, 2025, at 15:07, Shubham Khanna <khannashubham1197@gmail.com> wrote:


1.
```
+ if (dbinfo->made_publication)
+ drop_publication(conn, dbinfo->pubname, dbinfo->dbname,
+ &dbinfo->made_publication);
+ else
+ pg_log_info("preserve existing publication \"%s\" in database \"%s\"",
+ dbinfo->pubname, dbinfo->dbname);
+ }
```

Should we preserve “|| dry_run”? Because based on the old comment, in dry-run mode, even if we don’t create publications, we still want to inform the user.


We don’t need to add an explicit "|| dry_run" here, since the
made_publication flag already accounts for that case. In dry-run mode,
no publications are actually created, so made_publication is never
set. This ensures we still hit the “preserve existing publication …”
branch and inform the user accordingly.


I doubt that. Looking the code in create_publication():
if (!dry_run)
{
res = PQexec(conn, str->data);
if (PQresultStatus(res) != PGRES_COMMAND_OK)
{
pg_log_error("could not create publication \"%s\" in database \"%s\": %s",
dbinfo->pubname, dbinfo->dbname, PQresultErrorMessage(res));
disconnect_database(conn, true);
}
PQclear(res);
}

/* For cleanup purposes */
dbinfo->made_publication = true;

made_publication will always be set regardless of dry_run.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




В списке pgsql-hackers по дате отправления: