Re: [HACKERS] Fix bloom WAL tap test

On Wed, Sep 6, 2017 at 4:08 PM, Alexander Korotkov <a.korotkov@postgrespro.ru> wrote:

I just realized that these lines of contrib/bloom/t/001_wal.pl don't check that queries give same results on master and standby.  They just check that *return codes* of psql are equal.

# Run test queries and compare their result
my $master_result = $node_master->psql("postgres", $queries);
my $standby_result = $node_standby->psql("postgres", $queries);
is($master_result, $standby_result, "$test_name: query result matches");

Attached patch fixes this problem by using safe_psql() which returns psql output instead of return code.  For safety, this patch replaces psql() with safe_psql() in other places too.

I think this should be backpatched to 9.6 as bugfix.

Also, it would be nice to call wal-check on bloom check (now wal-check isn't called even on check-world).

See attached patch.  My changes to Makefile could be cumbersome.  Sorry for that, I don't have much experience with them...