Re: [HACKERS] Fix bloom WAL tap test
От | Alexander Korotkov |
---|---|
Тема | Re: [HACKERS] Fix bloom WAL tap test |
Дата | |
Msg-id | CAPpHfdtwOn=o0bACtcXrnexTmkyq=NoC0NzCY+UxCrf84CT+=w@mail.gmail.com обсуждение исходный текст |
Ответ на | [HACKERS] Fix bloom WAL tap test (Alexander Korotkov <a.korotkov@postgrespro.ru>) |
Ответы |
Re: [HACKERS] Fix bloom WAL tap test
|
Список | pgsql-hackers |
On Wed, Sep 6, 2017 at 4:08 PM, Alexander Korotkov <a.korotkov@postgrespro.ru> wrote:
Also, it would be nice to call wal-check on bloom check (now wal-check isn't called even on check-world).
I just realized that these lines of contrib/bloom/t/001_wal.pl don't check that queries give same results on master and standby. They just check that *return codes* of psql are equal.# Run test queries and compare their result
my $master_result = $node_master->psql("postgres", $queries);
my $standby_result = $node_standby->psql("postgres", $queries);
is($master_result, $standby_result, "$test_name: query result matches");Attached patch fixes this problem by using safe_psql() which returns psql output instead of return code. For safety, this patch replaces psql() with safe_psql() in other places too.I think this should be backpatched to 9.6 as bugfix.
See attached patch. My changes to Makefile could be cumbersome. Sorry for that, I don't have much experience with them...
The Russian Postgres Company
Вложения
В списке pgsql-hackers по дате отправления: