Re: set_cheapest without checking pathlist

Поиск
Список
Период
Сортировка
От Richard Guo
Тема Re: set_cheapest without checking pathlist
Дата
Msg-id CAMbWs48sDOcs2gAc2waft6aPtK+cdM-GqeZ0_Z=DKYT3Rcb97w@mail.gmail.com
обсуждение исходный текст
Ответ на Re: set_cheapest without checking pathlist  (David Rowley <dgrowleyml@gmail.com>)
Список pgsql-hackers

On Thu, Feb 1, 2024 at 5:03 PM David Rowley <dgrowleyml@gmail.com> wrote:
On Thu, 1 Feb 2024 at 19:36, Richard Guo <guofenglinux@gmail.com> wrote:
> maybe we can add an Assert or a comment clarifying that the pathlist of
> partially_grouped_rel cannot be empty here.

There'd be no need to Assert that as set_cheapest() will raise an
error when given a rel with an empty pathlist.

I don't think putting an Assert that would fail in the same situation
that we'd later ERROR out on would be a good idea. It'd make it harder
to debug the issue.

Fair point.

Thanks
Richard

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Quan Zongliang
Дата:
Сообщение: Re: Fix log_line_prefix to display the transaction id (%x) for statements not in a transaction block
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Make COPY format extendable: Extract COPY TO format implementations