Re: psql \watch versus \timing
От | Fujii Masao |
---|---|
Тема | Re: psql \watch versus \timing |
Дата | |
Msg-id | CAHGQGwFGB4x9XK7mrxLUngN+odkbAKOcHceXx161_AXJc1ydpg@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: psql \watch versus \timing (Michael Paquier <michael.paquier@gmail.com>) |
Список | pgsql-hackers |
On Tue, Oct 14, 2014 at 8:11 AM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Tue, Oct 14, 2014 at 4:49 AM, Bruce Momjian <bruce@momjian.us> wrote: >> On Thu, Sep 4, 2014 at 10:50:58PM +0900, Michael Paquier wrote: >>> On Thu, Sep 4, 2014 at 1:44 PM, Fujii Masao <masao.fujii@gmail.com> wrote: >>> > On Thu, Aug 28, 2014 at 8:46 PM, Fujii Masao <masao.fujii@gmail.com> wrote: >>> >> Good catch. So I will remove start_xact code later. >>> > Attached patch removes start_xact from PSQLexec. >>> Nothing negative to say here :) >>> Patch simply removes the second argument of PSQLexec that was set to >>> the same value everywhere, aka false as noticed by Heikki. Comments >>> and code blocks related to this parameter are removed, and the code >>> compiles, passing check-world as well (just kicked the tests in case). >> >> Uh, where are we on this? Should I commit it? > The patch cleaning up the dead code of psql could be clearly applied > now. For the feature itself not sure, it may be better to let > Fujii-san manage it. Applied. Regards, -- Fujii Masao
В списке pgsql-hackers по дате отправления: