Re: Separate memory contexts for relcache and catcache

Hi,

Have you checked what the source of the remaining allocations in
CacheMemoryContext are?

Given the size of both CatCacheMemoryContext and RelCacheMemoryContext in a
new backend, I think it might be worth using non-default aset parameters. A
bit ridiculous to increase block sizes from 8k upwards in every single
connection made to postgres ever.

> +static void
> +CreateCatCacheMemoryContext()

We typically use (void) to differentiate from an older way of function
declarations that didn't have argument types.

> +{
> +     if (!CacheMemoryContext)
> +             CreateCacheMemoryContext();

I wish we just made sure that cache memory context were created in the right
place, instead of spreading this check everywhere...

I'd just delete these comments, they're just pointlessly restating the code.