Re: Mingw task for Cirrus CI
| От | Melih Mutlu |
|---|---|
| Тема | Re: Mingw task for Cirrus CI |
| Дата | |
| Msg-id | CAGPVpCQLTq5QS-sDqTPfOstRpj2FUyqTQWx52F73LBs6d4WOJA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Mingw task for Cirrus CI (Andres Freund <andres@anarazel.de>) |
| Ответы |
Re: Mingw task for Cirrus CI
|
| Список | pgsql-hackers |
Hi hackers.
Andres Freund <andres@anarazel.de>, 22 Eyl 2022 Per, 20:03 tarihinde şunu yazdı:
Now that meson has been merged, could you try to adjust this patch so it
builds with meson?
Attached patch is the adjusted version to build with meson.
Add a commented-out trigger-type: manual and note in the commit message that
the committer needs to adjust that piece.
Done.
> Also: your original patch said --host=x86_64-w64-mingw32, but the task
> is called MinGW64. The most recent patches don't use --host at all, and
> were building for a 32 bit environment, even though the OS image says
> MSYSTEM=UCRT64.
I don't think you should need to use --host, that indicates cross compiling,
which we shouldn't do. I don't think the patch without --host targets 32bit -
the last time CI ran the patch, it built a 64bit PG:
Also removed this with meson changes. Can confirm that it builds 64bit.
Justin Pryzby <pryzby@telsasoft.com>, 5 Eyl 2022 Pzt, 14:50 tarihinde şunu yazdı:
I don't know what direction that idea is going, but it makes working
with this patch a bit easier when configure is less slow. Fine with me
to split it into a separate patch :)
If it's okay, then I would suggest not including that piece into this patch since I don't know what direction this is going either.
The patch has been changed quite a bit due to meson integration.
I would appreciate any feedback.Best,
Melih
Вложения
В списке pgsql-hackers по дате отправления: