Re: Mingw task for Cirrus CI

Hi,

On 2022-10-07 20:00:56 +0300, Melih Mutlu wrote:
> Attached patch is the adjusted version to build with meson.

Thanks!


> diff --git a/.cirrus.yml b/.cirrus.yml
> index 9f2282471a..7e6ebdf7b7 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -35,6 +35,7 @@ on_failure_ac: &on_failure_ac
>        - "**/*.log"
>        - "**/*.diffs"
>        - "**/regress_log_*"
> +      - "**/*.stackdump"
>      type: text/plain


I think it might be easier to just set MSYS=winjitdebug
https://www.msys2.org/wiki/JIT-Debugging/#native-windows-processes-started-from-msys2
and then rely on the existing windows crash reporting stuff.

>    setup_additional_packages_script: |
>      REM choco install -y --no-progress ...
> -
>    # Use /DEBUG:FASTLINK to avoid high memory usage during linking
>    configure_script: |

You removed a bunch of newlines here and nearby - I assume that wasn't
intentional?


> +  mingw_info_script:
> +    - C:\msys64\usr\bin\dash.exe -lc "where gcc"
> +    - C:\msys64\usr\bin\dash.exe -lc "gcc --version"
> +    - C:\msys64\usr\bin\dash.exe -lc "where perl"
> +    - C:\msys64\usr\bin\dash.exe -lc "perl --version"
> +
> +  configure_script:
> +    - C:\msys64\usr\bin\dash.exe -lc "cd %CIRRUS_WORKING_DIR% &&
> +      meson setup --buildtype debug -Dcassert=true -Db_pch=true -DTAR=%TAR% build"

There's no need to use dash anymore, the amount of shell script run is
minimal.


> +  build_script:
> +    - C:\msys64\usr\bin\dash.exe -lc "cd %CIRRUS_WORKING_DIR% && ninja -C %BUILD_DIR%"
> +  upload_caches: ccache
> +
> +  test_world_script:
> +    - C:\msys64\usr\bin\dash.exe -lc "cd %CIRRUS_WORKING_DIR% && meson test --print-errorlogs --num-processes
%TEST_JOBS%-C %BUILD_DIR%"
 
> +

I think the "cd"s here are superfluous given the ninja -C %BUILD_DIR% etc.

Greetings,

Andres Freund