On Tue, 5 Mar 2024 at 14:50, Japin Li <japinli@hotmail.com> wrote:
> Attach a patch to rewrite dispatch_table array using C99-designated
> initializer syntax.
Looks good. Two small things:
+ [EEOP_LAST] = &&CASE_EEOP_LAST,
Is EEOP_LAST actually needed in this array? It seems unused afaict. If
indeed not needed, that would be good to remove in an additional
commit.
- *
- * The order of entries needs to be kept in sync with the dispatch_table[]
- * array in execExprInterp.c:ExecInterpExpr().
I think it would be good to at least keep the comment saying that this
array should be updated (only the order doesn't need to be strictly
kept in sync anymore).