Re: Trivial fix for comment of function table_tuple_lock

Поиск
Список
Период
Сортировка
От Chao Li
Тема Re: Trivial fix for comment of function table_tuple_lock
Дата
Msg-id CAEoWx2m+H4nfbB3r=Rjy8xRQ4FhN=NcAOtZByfhde5+pU9duoA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Trivial fix for comment of function table_tuple_lock  (Fujii Masao <masao.fujii@gmail.com>)
Ответы Re: Trivial fix for comment of function table_tuple_lock
Список pgsql-hackers

On Mon, Sep 22, 2025 at 11:41 PM Fujii Masao <masao.fujii@gmail.com> wrote:

I noticed a few other issues. Wouldn’t it be better to fix these together?

* changingPart is listed as an output parameter for table_tuple_delete(),
    but it looks like an input.

Fixed. changingPart is of type bool, it cannot pass out anything.
 
* slot is listed as an input parameter for table_tuple_update(), but it seems
    to be an output.

Fixed. Yes, slot will get some field assigned inside the function.
 
* The comment for update_indexes in table_tuple_update() is mis-indented.

Fixed. Other parameters use a tab in front, while update_indexes used two white-space in front. 
 
* Not an issue, but it might be clearer to add a blank line between the input
    and output parameter comments in table_tuple_delete() and
    table_tuple_update().


Added new lines.
 
Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
https://www.highgo.com/
 
Вложения

В списке pgsql-hackers по дате отправления: