Re: Optimize Arm64 crc32c implementation in Postgresql

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема Re: Optimize Arm64 crc32c implementation in Postgresql
Дата
Msg-id CAEepm=0V6o6J+C2S3=Ev42SQUri-bnYvs9r+y1dBsaBenrripA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Optimize Arm64 crc32c implementation in Postgresql  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Optimize Arm64 crc32c implementation in Postgresql  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Optimize Arm64 crc32c implementation in Postgresql  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Список pgsql-hackers
Дерево обсуждения 
On Thu, May 3, 2018 at 2:30 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Do you really need the pg_crc32c_armv8_choose_dummy global variable?
> That seems pretty ugly.  If you're concerned about the compiler
> optimizing away the call to the crc function, you could write it like
>
>     result = (pg_comp_crc32c_armv8(0, 0, 0) == expected-value);
>
> which'd provide a bit of extra checking that the code's not broken,
> too.

True.  Of course I needed an interesting length too...

-- 
Thomas Munro
http://www.enterprisedb.com
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Hartmut Holzgraefe
Дата:
Сообщение: Re: Is a modern build system acceptable for older platforms
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Is a modern build system acceptable for older platforms