Re: Optimize Arm64 crc32c implementation in Postgresql

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: Optimize Arm64 crc32c implementation in Postgresql
Дата
в 17:30:39
Msg-id
17188.1525271439@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
Optimize Arm64 crc32c implementation in Postgresql Yuqi Gu <Yuqi.Gu@arm.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Michael Paquier <michael.paquier@gmail.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Andres Freund <andres@anarazel.de>
Re: Optimize Arm64 crc32c implementation in Postgresql Michael Paquier <michael@paquier.xyz>
Re: Optimize Arm64 crc32c implementation in Postgresql Andres Freund <andres@anarazel.de>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Andres Freund <andres@anarazel.de>
Re: Optimize Arm64 crc32c implementation in Postgresql Heikki Linnakangas <hlinnaka@iki.fi>
Re: Optimize Arm64 crc32c implementation in Postgresql Andres Freund <andres@anarazel.de>
Re: Optimize Arm64 crc32c implementation in Postgresql Heikki Linnakangas <hlinnaka@iki.fi>
Re: Optimize Arm64 crc32c implementation in Postgresql Andres Freund <andres@anarazel.de>
Re: Optimize Arm64 crc32c implementation in Postgresql Heikki Linnakangas <hlinnaka@iki.fi>
Re: Optimize Arm64 crc32c implementation in Postgresql Daniel Gustafsson <daniel@yesql.se>
Re: Optimize Arm64 crc32c implementation in Postgresql Heikki Linnakangas <hlinnaka@iki.fi>
Re: Optimize Arm64 crc32c implementation in Postgresql Tom Lane <tgl@sss.pgh.pa.us>
Re: Optimize Arm64 crc32c implementation in Postgresql Heikki Linnakangas <hlinnaka@iki.fi>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Heikki Linnakangas <hlinnaka@iki.fi>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Tom Lane <tgl@sss.pgh.pa.us>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Andrew Gierth <andrew@tao11.riddles.org.uk>
Re: Optimize Arm64 crc32c implementation in Postgresql Tom Lane <tgl@sss.pgh.pa.us>
Re: Optimize Arm64 crc32c implementation in Postgresql Tom Lane <tgl@sss.pgh.pa.us>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Tom Lane <tgl@sss.pgh.pa.us>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Tom Lane <tgl@sss.pgh.pa.us>
Re: Optimize Arm64 crc32c implementation in Postgresql Andrew Gierth <andrew@tao11.riddles.org.uk>
Re: Optimize Arm64 crc32c implementation in Postgresql Tom Lane <tgl@sss.pgh.pa.us>
Re: Optimize Arm64 crc32c implementation in Postgresql Tom Lane <tgl@sss.pgh.pa.us>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Andres Freund <andres@anarazel.de>
Re: Optimize Arm64 crc32c implementation in Postgresql Thomas Munro <thomas.munro@enterprisedb.com>
RE: Optimize Arm64 crc32c implementation in Postgresql Yuqi Gu <Yuqi.Gu@arm.com>
Re: Optimize Arm64 crc32c implementation in Postgresql Andres Freund <andres@anarazel.de>
Thomas Munro  writes:
> Ahh, OpenSSL's armcap.c shows how to do this.  You need to
> siglongjmp() out of there.  Here's a patch that does it that way.
> Isn't this better?

Do you really need the pg_crc32c_armv8_choose_dummy global variable?
That seems pretty ugly.  If you're concerned about the compiler
optimizing away the call to the crc function, you could write it like

    result = (pg_comp_crc32c_armv8(0, 0, 0) == expected-value);

which'd provide a bit of extra checking that the code's not broken,
too.

			regards, tom lane

В списке pgsql-hackers по дате отправления
От: Heikki Linnakangas
Дата:
От: Tom Lane
Дата:
FAQ