Re: [pgadmin4][patch] Use pytest test runner for unit tests

Поиск
Список
Период
Сортировка
От Joao De Almeida Pereira
Тема Re: [pgadmin4][patch] Use pytest test runner for unit tests
Дата
Msg-id CAE+jjam92a4rwYM+VxekLTRjLoWdAiPw4MuiCP1dUT_aWc5-6g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin4][patch] Use pytest test runner for unit tests  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgadmin4][patch] Use pytest test runner for unit tests
Список pgadmin-hackers
Дерево обсуждения
As part of the development environment we do not see the reasoning behind not add PYTHONPATH to the environment variables, specially because this looks like the way pytest was invisoned.

However please try the following patch instead. We've changed the pytest invocation to assume the relevant dir as part of the directories to load, as well as the docs and Makefile

Thanks
Joao && Anthony

On Thu, May 24, 2018 at 12:24 PM Dave Page <dpage@pgadmin.org> wrote:


On Thu, May 24, 2018 at 5:14 PM, Anthony Emengo <aemengo@pivotal.io> wrote:

Here’s a followup patch with the relevant README and Makefile changes. To be clear, both patches need to be applied in succession to run the tests.

The error that you were running into was because the appropriate PYTHONPATH environment variable was not set. We updated the README to reflect that, but haven’t done anything to the code for that

That really needs to be fixed then. I shouldn't need to do anything beyond activate the appropriate virtual environment (which I had done). 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения

В списке pgadmin-hackers по дате отправления: