Re: [pgadmin4][patch] Use pytest test runner for unit tests

Really? It's one more step that wasn't previously required, and for which there is no good reason when running in a properly configured virtual environment. Not only that, but PYTHONPATH is typically used as a search path to find modules on which the application/script is dependent - not to find the application/script itself. Unconditionally overriding it is likely to lead to problems in some possible configurations (at the very least I would expect to see the Makefile do PYTHONPATH=$PYTHONPATH:$(PWD)/web).

 

Some initial feedback:

- The JSON results are no longer being generated.

- The output is *extremely* verbose, showing a lot of seemingly unnecessary info (do we really need to output the source code of failing test cases?). I would suggest that the verbose output be directed to the log, and the visible output should be much more terse along the lines of what it is now.

- There is no summary at the end showing what passed, failed or was skipped. To figure out what to look at, I have to trawl through over 13K lines of output (642KB).

- 69 tests failed for me running test:unit. They were previously all passing.

- It is a *lot* faster - not sure if that's a result of tests failing, but I expect not entirely.

- /README was updated, but not /web/regression/README

Thanks.