Re: Missing file versions for a bunch of dll/exe files in Windows builds

On Thu, Apr 24, 2014 at 7:54 AM, Michael Paquier
<michael.paquier@gmail.com>wrote:

> Hi all,
>
> A colleague of mine pointed out that the file version is missing in a
> couple of dll and exe files when building on windows using the
> community scripts in src/tools/msvc. After having a closer look, I
> noticed that a *lot* of files are missing the shot:
> - all the exe/dll in contrib/
> - dll of PL languages (perl, python, tcl, pgsql)
> - libpqwalreceiver, snowball
> - ecpg stuff
> - regression and isolation test stuff
> - conversion_procs thingies
> Having a version number associated to a build is important for all
> companies creating builds of Postgres on Windows, so it would be good
> to have the patch attached applied and back-patched.
>
>
At least some fo that is intentional - things that are considered
"internal" were not given a version resource intentionally. E.g. the
conversion_procs is very intentional. The EXE/DLL in contrib should
definitely have them though.

it also seems like the wrong way to go about it - for all the other files,
it's added by rule (when PGFILEDESC is specified in the Makefile). Which
currently appears to be the *only* way it's added, so are you saying this
just doesn't work? Or does it work for some of them?

I think the proper solutioni s to add PGFILEDESC entries to the Makefile's,
and if that one doesn't actually work then fix the build system to work :)
(Sorry, don't have a win32 build environment around to test it right now)

Then it will be consistent between mingw and msvc, which your patch isn't,
I believe?


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/