Re: Missing file versions for a bunch of dll/exe files in Windows builds

On Thu, Apr 24, 2014 at 4:27 PM, Magnus Hagander <magnus@hagander.net> wrote:
> At least some fo that is intentional - things that are considered "internal"
> were not given a version resource intentionally. E.g. the conversion_procs
> is very intentional. The EXE/DLL in contrib should definitely have them
> though.
Why isn't conversion_procs done? Just to lower the maintenance pain?

> it also seems like the wrong way to go about it - for all the other files,
> it's added by rule (when PGFILEDESC is specified in the Makefile). Which
> currently appears to be the *only* way it's added, so are you saying this
> just doesn't work? Or does it work for some of them?
PGFILEDESC gets recognized, but not for any Makefile in contrib/. I am
guessing that a call to AddDir is missing when defining the contrib
projects. Just a guess from reading the code.

> I think the proper solutioni s to add PGFILEDESC entries to the Makefile's,
> and if that one doesn't actually work then fix the build system to work :)
> (Sorry, don't have a win32 build environment around to test it right now)
Yeah, that's what I thought, until I noticed that PGFILEDESC is only
defined in Makefile of contrib modules containing binaries
(pg_upgrade, oid2name, etc.). There is no documentation describing
this variable except what I could find in some archives of 2004.

> Then it will be consistent between mingw and msvc, which your patch isn't, I
> believe?
There is no reference in the source code to mingw. Am I missing smth?
--
Michael