Re: perlcritic

<p dir="ltr"><br /> On Sep 1, 2015 6:25 AM, "Michael Paquier" <<a
href="mailto:michael.paquier@gmail.com">michael.paquier@gmail.com</a>>wrote:<br /> ><br /> > On Tue, Sep 1,
2015at 12:57 PM, Peter Eisentraut <<a href="mailto:peter_e@gmx.net">peter_e@gmx.net</a>> wrote:<br /> > >
Wenow have 80+ Perl files in our tree, and it's growing.  Some of those<br /> > > files were originally written
forPerl 4, and the coding styles and<br /> > > quality are quite, uh, divergent.  So I figured it's time to clean
up<br/> > > that code a bit.  I ran perlcritic over the tree and cleaned up all the<br /> > > warnings at
level5 (the default, least severe).<br /> ><br /> > Do you think we should be concerned about the increased
difficultyto<br /> > backpatch fixes if this patch is applied? I personally think that's<br /> > fine to do this
cleanupon HEAD only, still others may have a<br /> > different opinion.<br /><p dir="ltr">It seems like something we
wantto do at some point, so we're going to have to take the pain at some point. <p dir="ltr">We might want to wait
untilafter we get 9.5 to rc as there's likely to be more changes then, but I don't see any point in delaying it  beyond
that.<p dir="ltr">/Magnus <br />