Re: Add shutdown_at_recovery_target option to recovery.conf

<div dir="ltr"><br /><br />On Thu, Dec 4, 2014 at 10:13 PM, Petr Jelinek <<a
href="mailto:petr@2ndquadrant.com">petr@2ndquadrant.com</a>>wrote:<br />> On 02/12/14 18:59, Robert Haas
wrote:<br/>>><br />>> On Fri, Nov 28, 2014 at 11:59 AM, Petr Jelinek <<a
href="mailto:petr@2ndquadrant.com">petr@2ndquadrant.com</a>><br/>>> wrote:<br />>>>>><br
/>>>>>>I'm a bit late to the party, but wouldn't<br />>>>>><br />>>>>>
recovery_target_action= ...<br />>>>>><br />>>>>> have been a better name for this? It'd
bein line with the other<br />>>>>> recovery_target_* parameters, and also a bit shorter than the
imho<br/>>>>>> somewhat ugly "action_at_recovery_target".<br />>>>><br />>>>><br
/>>>>>FWIW, I too think that "recovery_target_action" is a better name.<br />>>><br
/>>>><br/>>>> I agree.<br />>><br />>><br />>> +1.<br />>><br />><br
/>>Here is patch which renames action_at_recovery_target to<br />> recovery_target_action everywhere.<br
/>Thanks,Looks good to me.<br /><br />A couple of things that would be good to document as well in
recovery-config.sgml:<br/>- the fact that pause_at_recovery_target is deprecated.<br />- the fact that both parameters
cannotbe used at the same time.<br />Let's not surprise the users with behaviors they may expect or guess and document
thisstuff precisely..<br /><br />This would make docs consistent with this block of code in xlog.c:<br />        if
(recoveryPauseAtTargetSet&& actionAtRecoveryTargetSet)<br />                ereport(ERROR,<br />               
               (errcode(ERRCODE_INVALID_PARAMETER_VALUE),<br />                                 errmsg("cannot set both
\"%s\"and \"%s\" recovery parameters",<br />                                               
"pause_at_recovery_target",<br/>                                                "action_at_recovery_target"),<br />   
                            errhint("The \"pause_at_recovery_target\" is deprecated.")));<br /><br />Regards,<br />--
<br/>Michael</div>