Re: Add shutdown_at_recovery_target option to recovery.conf

<div dir="ltr"><br /><div class="gmail_extra"><br /><div class="gmail_quote">On Thu, Dec 4, 2014 at 10:45 PM, Michael
Paquier<span dir="ltr"><<a href="mailto:michael.paquier@gmail.com"
target="_blank">michael.paquier@gmail.com</a>></span>wrote:<br /><blockquote class="gmail_quote" style="margin:0px
0px0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><span class=""><br /><br />On Thu,
Dec4, 2014 at 10:13 PM, Petr Jelinek <<a href="mailto:petr@2ndquadrant.com"
target="_blank">petr@2ndquadrant.com</a>>wrote:<br />> On 02/12/14 18:59, Robert Haas wrote:<br />>><br
/>>>On Fri, Nov 28, 2014 at 11:59 AM, Petr Jelinek <<a href="mailto:petr@2ndquadrant.com"
target="_blank">petr@2ndquadrant.com</a>><br/>>> wrote:<br />>>>>><br />>>>>>
I'ma bit late to the party, but wouldn't<br />>>>>><br />>>>>> recovery_target_action =
...<br/>>>>>><br />>>>>> have been a better name for this? It'd be in line with the
other<br/>>>>>> recovery_target_* parameters, and also a bit shorter than the imho<br
/>>>>>>somewhat ugly "action_at_recovery_target".<br />>>>><br />>>>><br
/>>>>>FWIW, I too think that "recovery_target_action" is a better name.<br />>>><br
/>>>><br/>>>> I agree.<br />>><br />>><br />>> +1.<br />>><br />><br
/>>Here is patch which renames action_at_recovery_target to<br />> recovery_target_action everywhere.<br
/></span>Thanks,Looks good to me.<br /><br />A couple of things that would be good to document as well in
recovery-config.sgml:<br/>- the fact that pause_at_recovery_target is deprecated.<br />- the fact that both parameters
cannotbe used at the same time.<br />Let's not surprise the users with behaviors they may expect or guess and document
thisstuff precisely..<br /><span class=""></span></div></blockquote></div>Btw, you are missing as well the addition of
thisparameter in recovery.conf.sample (mentioned by Fujii-san upthread). It would be nice to have a description
paragraphas well similarly to what is written for pause_at_recovery_target.<br />-- <br /><div
class="gmail_signature">Michael<br/></div></div></div>