Re: pgsql: Add missing_ok option to the SQL functions for reading files.
От | Michael Paquier |
---|---|
Тема | Re: pgsql: Add missing_ok option to the SQL functions for reading files. |
Дата | |
Msg-id | CAB7nPqQYMd7+NADSTPHwCWaML37B6HQSNrhzNNS7-V6G94Vmmg@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: pgsql: Add missing_ok option to the SQL functions for reading files. (Bruce Momjian <bruce@momjian.us>) |
Ответы |
Re: pgsql: Add missing_ok option to the SQL functions
for reading files.
|
Список | pgsql-committers |
On Fri, Aug 28, 2015 at 9:39 PM, Bruce Momjian <bruce@momjian.us> wrote: > On Sun, Jul 5, 2015 at 08:44:41PM +0900, Michael Paquier wrote: >> On Mon, Jun 29, 2015 at 3:39 AM, Heikki Linnakangas >> <heikki.linnakangas@iki.fi> wrote: >> > Add missing_ok option to the SQL functions for reading files. >> > >> > This makes it possible to use the functions without getting errors, if there >> > is a chance that the file might be removed or renamed concurrently. >> > pg_rewind needs to do just that, although this could be useful for other >> > purposes too. (The changes to pg_rewind to use these functions will come in >> > a separate commit.) >> > >> > The read_binary_file() function isn't very well-suited for extensions.c's >> > purposes anymore, if it ever was. So bite the bullet and make a copy of it >> > in extension.c, tailored for that use case. This seems better than the >> > accidental code reuse, even if it's a some more lines of code. >> >> This has been done done as the part of a fix for the issues with >> pg_rewind, but perhaps it should be mentioned in the release notes? > > Yes, I will pick up that change during the creation of the 9.6 release > notes. Even if it has been introduced in 9.5? -- Michael
В списке pgsql-committers по дате отправления: