On Thu, Aug 28, 2014 at 4:20 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> I don't have strong opinion about this. There are many tables which
> regression test creates but doesn't drop. But if you strongly think that
> the table must be dropped, I'm OK with that.
This remark is just to limit the amount of trash in the database used
for regression tests. But then if we'd remove everything we would lack
handy material for tests on utilities like database-wide thingies of
the type VACUUM, REINDEX, pg_dump, etc. And we can just drop the
database used for regressions to clean up everything. So that's not
mandatory at all. I tend to always clean up objects in my patches
touching regressions to limit interactions with other tests, but I
guess that's up to the person who wrote the code to decide.
--
Michael