Re: error context for vacuum to include block number

On Fri, 27 Mar 2020 at 07:17, Justin Pryzby <pryzby@telsasoft.com> wrote:
>
> On Thu, Mar 26, 2020 at 10:04:57AM -0500, Justin Pryzby wrote:
> > Does that address your comment ?
>
> I hope so.

Thank you for updating the patch. I'm concerned a bit about overhead
of frequently updating and reverting the callback arguments in
lazy_vacuum_page(). We call that function every time when we vacuum a
page, but if the table has an index, we actually don't need to update
the callback arguments in that function. But I hope it's negligible
since all operation will be performed on memory.

Regards,

--
Masahiko Sawada            http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services