Re: palloc unification

On Wed, Feb 6, 2013 at 9:38 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Robert Haas escribió:
>> On Mon, Feb 4, 2013 at 5:50 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
>> > I propose to have a new subdirectory src/include/shared, and two
>> > header files:
>
>> > The frontend (pg_malloc) function definitions would live somewhere in,
>> > say, src/shared/fe_memutils.c.  For the palloc() implementation, I think
>> > we should create another file, so that frontend-only programs that do
>> > not require those symbols (most of them) are not unnecessarily bloated.
>> >
>> > Opinions on having a new subdir?
>
>> I like the idea of having a place for shared frontend and backend code
>> very much, but I don't think src/include/shared or src/shared is a
>> good name, because "shared" can mean a lot of things - like "shared
>> library", for example.  I think that this should be set up in a manner
>> analogous to libpgport, except not for portability code, but instead
>> for other stuff.  Maybe we could call it libpgframework or something.
>
> Yeah, I am doing this right now and the "shared" name doesn't seem so
> good.  "libpgframework" sounds decent.  So since libpgport comes from
> src/port, are we okay with src/framework and src/include/framework?

That seems reasonable to me.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company