Re: Removing xloginsert_slots?

On Wed, Jan 29, 2014 at 8:22 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> Hi,
>
> On 2014-01-29 21:59:05 +0900, Michael Paquier wrote:
>> The undocumented GUC called xloginsert_slots has been introduced by
>> commit 9a20a9b. It is mentioned by the commit that this parameter
>> should be removed before the release. Wouldn't it be a good time to
>> remove this parameter soon? I imagine that removing it before the beta
>> would make sense so now is perhaps too early... Either way, attached
>> is a patch doing so...
>
> I'd rather wait till somebody actually has done some benchmarks. I don't
> think we're more clueful about it now than back when the patch went
> in. And such benchmarking is more likely during beta, so...

Well, it's either got to go away, or get documented, IMHO.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company