Re: TABLESAMPLE patch

On Wed, Apr 1, 2015 at 12:15 PM, Petr Jelinek <petr@2ndquadrant.com> wrote:
> REPEATABLE is mandated by standard. I did try for quite some time to make it
> unreserved but was not successful (I can only make it unreserved if I make
> it mandatory but that's not a solution). I haven't been in fact even able to
> find out what it actually conflicts with...

Yeah, that can be hard to figure out.  Did you run bison with -v and
poke around in gram.output?

> METHOD is something I added. I guess we could find a way to name this
> differently if we really tried. The reason why I picked METHOD was that I
> already added the same unreserved keyword in the sequence AMs patch and in
> that one any other name does not really make sense.

I see.  Well, I guess if we've got more than one use for it it's not so bad.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company