Re: TABLESAMPLE patch

On 01/04/15 18:38, Robert Haas wrote:
> On Wed, Apr 1, 2015 at 12:15 PM, Petr Jelinek <petr@2ndquadrant.com> wrote:
>> REPEATABLE is mandated by standard. I did try for quite some time to make it
>> unreserved but was not successful (I can only make it unreserved if I make
>> it mandatory but that's not a solution). I haven't been in fact even able to
>> find out what it actually conflicts with...
>
> Yeah, that can be hard to figure out.  Did you run bison with -v and
> poke around in gram.output?
>

Oh, no I didn't (I didn't know gram.output will be generated). This 
helped quite a bit. Thanks.

I now found the reason, it's conflicting with alias but that's my 
mistake - alias should be before TABLESAMPLE clause as per standard and 
I put it after in parser. Now that I put it at correct place REPEATABLE 
can be unreserved keyword. This change requires making TABLESAMPLE a 
"type_func_name_keyword" but that's probably not really an issue as 
TABLESAMPLE is reserved keyword per standard.

--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services