Re: Add regression coverage for REVOKE ADMIN OPTION
От | Daniel Gustafsson |
---|---|
Тема | Re: Add regression coverage for REVOKE ADMIN OPTION |
Дата | |
Msg-id | C7F8FCB8-671E-476F-B606-C641E19AF4E0@yesql.se обсуждение исходный текст |
Ответ на | Add regression coverage for REVOKE ADMIN OPTION (Mark Dilger <mark.dilger@enterprisedb.com>) |
Ответы |
Re: Add regression coverage for REVOKE ADMIN OPTION
|
Список | pgsql-hackers |
> On 16 Nov 2021, at 00:58, Mark Dilger <mark.dilger@enterprisedb.com> wrote: > While working on a fix for dangling references to dropped roles in the pg_auth_members.grantor field, I happened to noticewe entirely lack regression test coverage of the REVOKE ADMIN OPTION FOR form of the RevokeRoleStmt. I am unawareof any bugs in the current implementation, but future work on roles may benefit if we close the testing gap. LGTM. Reading this I realized that the GRANTED BY keyword for RevokeRoleStmt isn't working as documented, it's not checking the role at all. I've sent a diff for that with tests on the relevant thread, but I think it would be a good to get this in too to boost coverage. -- Daniel Gustafsson https://vmware.com/
В списке pgsql-hackers по дате отправления: