Re: create tablespace fails silently, or succeeds improperly

On Mon, Oct 18, 2010 at 2:17 PM, Bruce Momjian <bruce@momjian.us> wrote:
> Dave Cramer wrote:
>> On Mon, Oct 18, 2010 at 11:37 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> > Dave Cramer <pg@fastcrypt.com> writes:
>> >> as seen below create tablespace does not throw an error or appear to
>> >> do anything other than register the tablespace.
>> >
>> > I suspect this behavior is partially intentional, because tablespace
>> > creation now involves an extra level of subdirectory. ?However, it's
>> > not clear to me why CREATE TABLESPACE is still changing the permissions
>> > on the parent directory. ?Bruce, exactly what is the rationale here?
>>
>> OK, it appears there are a few loose ends here then as the
>> documentation http://www.postgresql.org/docs/9.0/interactive/sql-createtablespace.html
>> says the directory needs to be empty.
>
> Docs updated to say "should", not "must", be empty.  Backpatched to
> 9.0.X.  If we need more change, I can do those too.

Perhaps we should fix the behavior rather than the documentation.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company