Re: create tablespace fails silently, or succeeds improperly

Dave Cramer wrote:
> On Mon, Oct 18, 2010 at 11:37 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Dave Cramer <pg@fastcrypt.com> writes:
> >> as seen below create tablespace does not throw an error or appear to
> >> do anything other than register the tablespace.
> >
> > I suspect this behavior is partially intentional, because tablespace
> > creation now involves an extra level of subdirectory. ?However, it's
> > not clear to me why CREATE TABLESPACE is still changing the permissions
> > on the parent directory. ?Bruce, exactly what is the rationale here?
>
> OK, it appears there are a few loose ends here then as the
> documentation http://www.postgresql.org/docs/9.0/interactive/sql-createtablespace.html
> says the directory needs to be empty.

Docs updated to say "should", not "must", be empty.  Backpatched to
9.0.X.  If we need more change, I can do those too.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +
diff --git a/doc/src/sgml/ref/create_tablespace.sgml b/doc/src/sgml/ref/create_tablespace.sgml
index 24fb79e..beda454 100644
--- a/doc/src/sgml/ref/create_tablespace.sgml
+++ b/doc/src/sgml/ref/create_tablespace.sgml
@@ -81,7 +81,7 @@ CREATE TABLESPACE <replaceable class="parameter">tablespace_name</replaceable> [
       <listitem>
        <para>
         The directory that will be used for the tablespace. The directory
-        must be empty and must be owned by the
+        should be empty and must be owned by the
         <productname>PostgreSQL</> system user.  The directory must be
         specified by an absolute path name.
        </para>