Re: [HACKERS] reviewers needed!
От | Ibrar Ahmed |
---|---|
Тема | Re: [HACKERS] reviewers needed! |
Дата | |
Msg-id | AANLkTimBkorS53uD9TSKxhDh3bo+8+YY++8QSTxhqQrV@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [HACKERS] reviewers needed! (Robert Haas <robertmhaas@gmail.com>) |
Ответы |
Re: [HACKERS] reviewers needed!
|
Список | pgsql-rrreviewers |
Hi! I can join as an RRR, if its still needed. -- Ibrar Ahmed EnterpriseDB Corporation The Enterprise Postgres Company On Mon, Jan 17, 2011 at 3:10 AM, Robert Haas <robertmhaas@gmail.com> wrote: > On Sun, Jan 16, 2011 at 2:30 PM, Andy Colson <andy@squeakycode.net> wrote: >> I reviewed a couple patched, and I added my review to the commitfest page. >> >> If I find a problem, its obvious I should mark the patch as "returned with >> feedback". > > Only if it's got sufficiently serious flaws that getting it committed > during this CommitFest is not practical. If it just needs some > revision, "Waiting on Author" is the right place. > >> But what if I'm happy with it? I'm not a hacker so cannot do C code review, >> should I leave it alone? Mark it as "ready for committer"? > > Yep, that's fine. > > -- > Robert Haas > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- > Sent via pgsql-rrreviewers mailing list (pgsql-rrreviewers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-rrreviewers >
В списке pgsql-rrreviewers по дате отправления: