Re: review: xml_is_well_formed

2010/8/2 Pavel Stehule <pavel.stehule@gmail.com>:
> 2010/7/31 Robert Haas <robertmhaas@gmail.com>:
>> On Sat, Jul 31, 2010 at 8:10 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
>>> On fre, 2010-07-30 at 12:50 +0100, Mike Fowler wrote:
>>>> > * xml_is_well_formed returns true for simple text
>>>> >
>>>> > postgres=# SELECT xml_is_well_formed('ssss');
>>>> >   xml_is_well_formed
>>>> > --------------------
>>>> >   t
>>>> > (1 row)
>>>> >
>>>> > it is probably wrong result - is it ok??
>>>> >
>>>>
>>>> Yes this is OK, pure text is valid XML content.
>>>
>>> Are you speaking of XML content fragments that SQL/XML defines?
>>>
>>> Well-formedness should probably only allow XML documents.
>>
>> I think the point of this function is to determine whether a cast to
>> xml will throw an error.  The behavior should probably match exactly
>> whatever test would be applied there.
>
> I agree with this idea - so I am able to do:
>
> postgres=# select 'xxx'::xml;
>  xml
> -----
>  xxx
> (1 row)
>
> I have not any suggestions now - so I'll change flag to "ready to commit"

sorry - contrib module should be a fixed

patch attached


>
> Regards
>
> Pavel Stehule
>
>>
>> --
>> Robert Haas
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise Postgres Company
>>
>