> On 19 Feb 2024, at 15:17, Japin Li <japinli@hotmail.com> wrote:
>
>
> +1
PFA patch set of 4 patches:
1. remove all potential flaky tests. BTW recently we had a bingo when 3 of them failed together [0]
2-3. waiting injection points patchset by Michael Paquier, intact v2 from nearby thread.
4. prototype of simple TAP tests for timeouts.
I did not add a test for statement_timeout, because it still have good coverage in isolation tests. But added test for
idle_sessoin_timeout.
Maybe these tests could be implemented with NOTICE injection points (not requiring steps 2-3), but I'm afraid that they
mightbe flaky too: FATALed connection might not send information necesary for test success (we will see something like
"PQconsumeInputfailed: server closed the connection unexpectedly" as in [1]).
Best regards, Andrey Borodin.
[0] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tamandua&dt=2024-02-20%2010%3A20%3A13
[1] https://www.postgresql.org/message-id/flat/CAAhFRxiQsRs2Eq5kCo9nXE3HTugsAAJdSQSmxncivebAxdmBjQ%40mail.gmail.com