Re: --with-llvm on 32-bit platforms?
От | Tom Lane |
---|---|
Тема | Re: --with-llvm on 32-bit platforms? |
Дата | |
Msg-id | 952445.1758030310@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: --with-llvm on 32-bit platforms? (Thomas Munro <thomas.munro@gmail.com>) |
Ответы |
Re: --with-llvm on 32-bit platforms?
|
Список | pgsql-hackers |
Thomas Munro <thomas.munro@gmail.com> writes: > On Tue, Sep 16, 2025 at 12:51 PM Thomas Munro <thomas.munro@gmail.com> wrote: >> On Tue, Sep 16, 2025 at 12:05 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> Oh! Yeah, that is surely broken now. > This patch seems to work OK here. The deform code is a little tricky > as you have to think carefully about which places need TypeDatum and > which need TypeSizeT in llvmjit_deform.c, since the v_offp variable > really is size_t. Tested on Debian 13 with i386 packages installed. Thanks for doing that. It looks generally plausible to my eye, but I'm hardly qualified to do a detailed review. > More changes would be needed if Datum is changed into a struct. I can only imagine us doing that as a compile option to help catch errors. Our ambition need not reach to making the compile option play with --with-llvm, perhaps. regards, tom lane
В списке pgsql-hackers по дате отправления: