Re: Weird test mixup
От | Heikki Linnakangas |
---|---|
Тема | Re: Weird test mixup |
Дата | |
Msg-id | 8e4cf596-dd70-432e-9068-16466ed596ed@iki.fi обсуждение исходный текст |
Ответ на | Re: Weird test mixup (Heikki Linnakangas <hlinnaka@iki.fi>) |
Ответы |
Re: Weird test mixup
Re: Weird test mixup |
Список | pgsql-hackers |
On 15/03/2024 13:09, Heikki Linnakangas wrote: > On 15/03/2024 01:13, Tom Lane wrote: >> Michael Paquier <michael@paquier.xyz> writes: >>> Or we could just disable runningcheck because of the concurrency >>> requirement in this test. The test would still be able to run, just >>> less times. >> >> No, actually we *must* mark all these tests NO_INSTALLCHECK if we >> stick with the current definition of injection points. The point >> of installcheck mode is that the tests are supposed to be safe to >> run in a live installation. Side-effects occurring in other >> databases are completely not OK. > > I committed a patch to do that, to put out the fire. That's turning the buildfarm quite red. Many, but not all animals are failing like this: > --- /home/buildfarm/hippopotamus/buildroot/HEAD/pgsql.build/src/test/modules/injection_points/expected/injection_points.out 2024-03-15 12:41:16.363286975 +0100 > +++ /home/buildfarm/hippopotamus/buildroot/HEAD/pgsql.build/src/test/modules/injection_points/results/injection_points.out 2024-03-15 12:53:11.528159615 +0100 > @@ -1,118 +1,111 @@ > CREATE EXTENSION injection_points; > +ERROR: extension "injection_points" is not available > +DETAIL: Could not open extension control file "/home/buildfarm/hippopotamus/buildroot/HEAD/pgsql.build/tmp_install/home/buildfarm/hippopotamus/buildroot/HEAD/inst/share/postgresql/extension/injection_points.control": Nosuch file or directory. > +HINT: The extension must first be installed on the system where PostgreSQL is running. > ... Looks like adding NO_INSTALLCHECK somehow affected how the modules are installed in tmp_install. I'll investigate.. -- Heikki Linnakangas Neon (https://neon.tech)
В списке pgsql-hackers по дате отправления: