> On 16 Dec 2023, at 05:58, Japin Li <japinli@hotmail.com> wrote:
>
>
> On Fri, 15 Dec 2023 at 17:51, Andrey M. Borodin <x4mmm@yandex-team.ru> wrote:
>>> On 8 Dec 2023, at 15:29, Japin Li <japinli@hotmail.com> wrote:
>>>
>>> Thanks for updating the patch. LGTM.
>>
>> PFA v9. Changes:
>> 1. Added tests for idle_in_transaction_timeout
>> 2. Suppress statement_timeout if it’s shorter than transaction_timeout
>>
> + if (StatementTimeout > 0
> + && IdleInTransactionSessionTimeout < TransactionTimeout)
> ^
>
> Should be StatementTimeout?
Yes, that’s an oversight. I’ve adjusted tests so they catch this problem.
> Maybe we should add documentation to describe this behavior.
I've added a paragraph about it to config.sgml, but I'm not sure about the comprehensiveness of the wording.
Best regards, Andrey Borodin.