Re: Ordering of header file inclusion

diff --git a/contrib/bloom/blcost.c b/contrib/bloom/blcost.c
index f9fe57f..6224735 100644
--- a/contrib/bloom/blcost.c
+++ b/contrib/bloom/blcost.c
@@ -12,10 +12,10 @@
  */
 #include "postgres.h"

+#include "bloom.h"
 #include "fmgr.h"
 #include "utils/selfuncs.h"

-#include "bloom.h"

 /*
  * Estimate cost of bloom index scan.

This class of change I don't like.

The existing arrangement keeps "other" header files separate from the
header file of the module itself.  It seems useful to keep that separate.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services